[BugFix] Fix minimax m2 model partial_rotary_factor#30486
Closed
rogeryoungh wants to merge 2 commits intovllm-project:mainfrom
Closed
[BugFix] Fix minimax m2 model partial_rotary_factor#30486rogeryoungh wants to merge 2 commits intovllm-project:mainfrom
rogeryoungh wants to merge 2 commits intovllm-project:mainfrom
Conversation
rotary_dim when `partial_rotary_factor…
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a compatibility issue with older quantized models by conditionally setting the rotary_dim. While the overall logic seems correct, I've identified a critical issue in the implementation that could lead to an UnboundLocalError at runtime. My review includes a suggested fix for this issue.
…` is not set Signed-off-by: xuebi <xuebi@minimaxi.com>
4307d3f to
febeada
Compare
Signed-off-by: xuebi <xuebi@minimaxi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In #30384, I fixed an inference issue with MiniMax-M2, but this caused some community-contributed quantized models to fail(#30445), some of which were forked before I added
partial_rotary_factor. This update provides compatibility with those community-contributed quantized models.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.