Make the httpx logger less annoying when Transformers v5 is installed#30480
Merged
hmellor merged 1 commit intovllm-project:mainfrom Dec 11, 2025
Merged
Make the httpx logger less annoying when Transformers v5 is installed#30480hmellor merged 1 commit intovllm-project:mainfrom
httpx logger less annoying when Transformers v5 is installed#30480hmellor merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to reduce the verbosity of the httpx logger by setting its level to WARNING when the main vLLM logger is at the default INFO level. The implementation correctly handles this case, but it fails to adjust the httpx logger level when a non-default level (like DEBUG) is set, which contradicts one of the stated goals of the PR. I've provided a suggestion to fix this logical issue to ensure httpx logging level matches the user's configuration for all non-default cases.
DarkLight1337
approved these changes
Dec 11, 2025
github-actions
bot
added
the
ready
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…ed (vllm-project#30480) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…ed (vllm-project#30480) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfor ers v5 uses
httpxto access the Hugging Face Hub. When its logger is set toINFO, the logging output is quite verbose.This PR sets
httpx's logging level toWARNINGwhen vLLM's logging level is default (INFO) so that:httpxwill follow