Skip to content

[Deprecation] Deprecation --convert reward, use --convert embed instead.#30463

Merged
DarkLight1337 merged 3 commits intovllm-project:mainfrom
noooop:convert_reward
Dec 11, 2025
Merged

[Deprecation] Deprecation --convert reward, use --convert embed instead.#30463
DarkLight1337 merged 3 commits intovllm-project:mainfrom
noooop:convert_reward

Conversation

@noooop
Copy link
Collaborator

@noooop noooop commented Dec 11, 2025

Purpose

Follow #26686

We are going to remove --convert reward in v0.15, use --convert embed instead.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify
Copy link

mergify bot commented Dec 11, 2025

Documentation preview: https://vllm--30463.org.readthedocs.build/en/30463/

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 11, 2025
@mergify
Copy link

mergify bot commented Dec 11, 2025

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the --convert reward option in favor of --convert embed. The changes include updating the documentation to reflect this deprecation and modifying the model configuration logic to handle the deprecated value by issuing a warning and mapping it to embed. The implementation is straightforward, but the warning message in the code could be clearer and has a minor typo.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify the version (I suggest v0.15)

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 11, 2025 07:52
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 11, 2025
@DarkLight1337 DarkLight1337 merged commit a5f9fb5 into vllm-project:main Dec 11, 2025
50 of 51 checks passed
@noooop noooop deleted the convert_reward branch December 11, 2025 10:21
Majid-Taheri pushed a commit to Majid-Taheri/vllm that referenced this pull request Dec 23, 2025
…nstead. (vllm-project#30463)

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…nstead. (vllm-project#30463)

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants