[Deprecation] Deprecation --convert reward, use --convert embed instead.#30463
[Deprecation] Deprecation --convert reward, use --convert embed instead.#30463DarkLight1337 merged 3 commits intovllm-project:mainfrom
--convert reward, use --convert embed instead.#30463Conversation
|
Documentation preview: https://vllm--30463.org.readthedocs.build/en/30463/ |
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
There was a problem hiding this comment.
Code Review
This pull request deprecates the --convert reward option in favor of --convert embed. The changes include updating the documentation to reflect this deprecation and modifying the model configuration logic to handle the deprecated value by issuing a warning and mapping it to embed. The implementation is straightforward, but the warning message in the code could be clearer and has a minor typo.
242599f to
2a8572c
Compare
DarkLight1337
left a comment
There was a problem hiding this comment.
Please specify the version (I suggest v0.15)
…nstead. (vllm-project#30463) Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
…nstead. (vllm-project#30463) Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Purpose
Follow #26686
We are going to remove
--convert rewardin v0.15, use--convert embedinstead.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.