[V0 Deprecation] Deprecate use_v1#30415
Closed
MatthewBonanni wants to merge 1 commit intovllm-project:mainfrom
Closed
[V0 Deprecation] Deprecate use_v1#30415MatthewBonanni wants to merge 1 commit intovllm-project:mainfrom
MatthewBonanni wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Documentation preview: https://vllm--30415.org.readthedocs.build/en/30415/ |
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully removes the deprecated use_v1 parameter from get_attn_backend_cls and its associated logic, along with the corresponding documentation entry. The changes are clean and align with the planned deprecation schedule. No critical or high-severity issues were found.
Collaborator
Author
|
Closing in favor of #30396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
use_v1argument ofget_attn_backend_clswas scheduled for removal in v0.13.0. This PR removes it.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.