Skip to content

[V0 Deprecation] Deprecate use_v1#30415

Closed
MatthewBonanni wants to merge 1 commit intovllm-project:mainfrom
MatthewBonanni:deprecate_use_v1
Closed

[V0 Deprecation] Deprecate use_v1#30415
MatthewBonanni wants to merge 1 commit intovllm-project:mainfrom
MatthewBonanni:deprecate_use_v1

Conversation

@MatthewBonanni
Copy link
Copy Markdown
Collaborator

@MatthewBonanni MatthewBonanni commented Dec 10, 2025

Purpose

The use_v1 argument of get_attn_backend_cls was scheduled for removal in v0.13.0. This PR removes it.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 10, 2025

Documentation preview: https://vllm--30415.org.readthedocs.build/en/30415/

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 10, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the deprecated use_v1 parameter from get_attn_backend_cls and its associated logic, along with the corresponding documentation entry. The changes are clean and align with the planned deprecation schedule. No critical or high-severity issues were found.

@MatthewBonanni
Copy link
Copy Markdown
Collaborator Author

Closing in favor of #30396

@MatthewBonanni MatthewBonanni deleted the deprecate_use_v1 branch December 10, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant