Skip to content

fix(gguf): Ensure Gemma2 configs have hidden_act for backward compatibility #30411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kitaekatt wants to merge 1 commit into from
Closed

fix(gguf): Ensure Gemma2 configs have hidden_act for backward compatibility #30411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions vllm/config/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,17 @@ def __post_init__(
)

self.hf_config = hf_config

# Ensure Gemma2 configs have hidden_act for backward compatibility.
# GGUF configs may only have hidden_activation; model code expects both.
if (
hasattr(hf_config, "model_type")
and hf_config.model_type == "gemma2"
and not hasattr(hf_config, "hidden_act")
and hasattr(hf_config, "hidden_activation")
):
hf_config.hidden_act = hf_config.hidden_activation

if dict_overrides:
self._apply_dict_overrides(hf_config, dict_overrides)
self.hf_text_config = get_hf_text_config(self.hf_config)
Expand Down