[BugFix] Fix AttributeError: 'MergedColumnParallelLinear' object has no attribute 'weight_scale'#30399
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Dec 10, 2025
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
mgoin
approved these changes
Dec 10, 2025
mgoin
added
bug
yewentao256
approved these changes
Dec 10, 2025
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
Contributor
|
LGTM, also fixes the same problem with |
Collaborator
|
@LucasWilkinson noob q, why #30267 broke this? |
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
… no attribute 'weight_scale'` (vllm-project#30399) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
… no attribute 'weight_scale'` (vllm-project#30399) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#30267 introduced a
failure in
tests/quantization/test_blackwell_moe.py::test_deepseek_fp8_block_moe_deep_gemmin Blackwell Quantized MoE Test)FIX #28480 (comment)