Standardise get_rope to use rope_parameters["partial_rotary_factor"], not rotary_dim#30389
Merged
hmellor merged 17 commits intovllm-project:mainfrom Dec 11, 2025
Merged
Standardise get_rope to use rope_parameters["partial_rotary_factor"], not rotary_dim#30389hmellor merged 17 commits intovllm-project:mainfrom
get_rope to use rope_parameters["partial_rotary_factor"], not rotary_dim#30389hmellor merged 17 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
WoosukKwon,
mgoin,
patrickvonplaten,
sighingnow,
tlrmchlsmth and
yewentao256
as code owners
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
mergify
bot
added
deepseek
hmellor
changed the title
get_rope to use rope_parameters["partial_rotary_factor"], not rotary_dim
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the get_rope function by removing the rotary_dim argument and deriving it from head_size and partial_rotary_factor instead. The changes are applied across a large number of model files. The refactoring is well-executed, but I've found several instances where the shared config object is modified in-place. This can lead to unexpected side effects and should be avoided. I've provided suggestions to create copies of rope_parameters before modification to prevent this.
DarkLight1337
approved these changes
Dec 10, 2025
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
Isotr0py
approved these changes
Dec 10, 2025
Member
|
Can you resolve the merge conflict? |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
esmeetu
reviewed
Dec 11, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
1 task
…n-standard names Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
ProExpertProg,
houseroad,
robertgshaw2-redhat and
youkaichao
as code owners
5 tasks
1 task
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…"]`, not `rotary_dim` (vllm-project#30389) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…"]`, not `rotary_dim` (vllm-project#30389) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #30349 (comment).
Globally applies the fix from #30384.
rotary_dimas a config field only exists in GPT-J and a few custom models (Minimax for example). The Transformers library has standardised onpartial_rotary_factorwhich lives inrope_parameters.This PR removes the
rotary_dimargument fromget_ropeso that there is now only one way to set therotary_dimfor RoPE:rope_parameterswithpartial_rotary_factorspopulatedget_ropedoesrotary_dim = head_dim * partial_rotary_factorinternallyFor the few edge cases that did not set
config.rope_parameters["partial_rotary_factor"]it has been reverse engineered fromconfig.rotary_dim.