Skip to content

[Fix] Add default rope theta for qwen1 model #30369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iwzbi wants to merge 1 commit into from
+2 −0
Closed

[Fix] Add default rope theta for qwen1 model #30369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vllm/model_executor/models/qwen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
)
from vllm.model_executor.model_loader.weight_utils import default_weight_loader
from vllm.sequence import IntermediateTensors
from vllm.transformers_utils.config import set_default_rope_theta

from .interfaces import SupportsLoRA, SupportsPP
from .utils import (
Expand Down Expand Up @@ -149,6 +150,7 @@ def __init__(
prefix: str = "",
):
super().__init__()
set_default_rope_theta(config, default_theta=10000)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Calling set_default_rope_theta in QWenBlock.__init__ is inefficient as it's executed for every model layer. This function should be called only once per model initialization.

Please move this call to the beginning of QWenModel.__init__ (e.g., after line 201) to ensure it runs only once. This will improve model loading efficiency and align with best practices seen in other models in this repository.

self.ln_1 = RMSNorm(config.hidden_size, eps=config.layer_norm_epsilon)

self.attn = QWenAttention(
Expand Down