Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Code Review
This pull request removes the virtual_engine field and its handling throughout the codebase. The changes simplify KV cache access by assuming a single cache instance instead of a list indexed by virtual_engine. The modifications are consistently applied across various components, including attention layers, KV connectors, model implementations, and tests. The refactoring is clean and aligns with the goal of simplifying the KV cache management. I have reviewed the changes and found no issues.
|
Hi maintainers, quick question about scope: Does this PR also cover the TODO in Right now |
Summary
Testing
Codex Task