[cpu][ci] Add CPU Attention Tests for Neon Backend#30347
[cpu][ci] Add CPU Attention Tests for Neon Backend#30347bigPYJ1151 merged 1 commit intovllm-project:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Code Review
This pull request adds CPU attention tests for the Neon backend, which is a good addition for ensuring correctness on ARM platforms. The changes include a new test case specifically for Neon and modifications to existing tests to dynamically select the appropriate instruction set architecture (ISA).
My review identified two critical issues in the implementation of these tests. First, a new helper function get_attn_isa contains a latent bug that would cause a TypeError if called with an argument. Second, the new Neon-specific test has an incorrect skipif condition, causing it to be skipped on the intended ARM hardware and run on other platforms where it is not applicable. I've provided suggestions to fix both issues to ensure the tests function as intended.
86c9591 to
39cf2ab
Compare
|
@mgoin / @bigPYJ1151 could you guys have a look? |
|
Hi @fadara01, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Should really have been part of vllm-project#29193 but I missed it Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
39cf2ab to
5ff4735
Compare
Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Purpose
Add CPU Attention Tests for Neon Backend
Should really have been part of #29193 but I missed it
Test Plan
Arm CI which includes CPU attention tests.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.