[BugFix] Spec decode with VLLM_ENABLE_V1_MULTIPROCESSING=0#30319
Merged
njhill merged 4 commits intovllm-project:mainfrom Dec 18, 2025
Merged
[BugFix] Spec decode with VLLM_ENABLE_V1_MULTIPROCESSING=0#30319njhill merged 4 commits intovllm-project:mainfrom
njhill merged 4 commits intovllm-project:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix speculative decoding when not using multiprocessing by adding a call to post_step. While the change correctly identifies the missing call, the implementation hardcodes model_executed=True. This could lead to issues if step_fn is called without the model actually executing. I've provided a suggestion to use the model_executed flag returned by step_fn to ensure correctness and maintain consistency with the multiprocessing implementation.
5 tasks
5 tasks
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Dec 22, 2025
…ect#30319) Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…ect#30319) Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
4 tasks
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…ect#30319) Signed-off-by: Chen Zhang <zhangch99@outlook.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…ect#30319) Signed-off-by: Chen Zhang <zhangch99@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We now forgets to pass the draft tokens from model runner to scheduler. This PR fix it.
Test Plan
Test Result
Before this PR:
After this PR:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.