fix: DeepSeek-V3.2 DeepGEMM RuntimeError#30251
fix: DeepSeek-V3.2 DeepGEMM RuntimeError#30251KeeProMise wants to merge 3 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses a RuntimeError in DeepSeek-V3.2 DeepGEMM by introducing a crucial alignment check for the input K dimension. The changes correctly extend the should_use_deepgemm_for_fp8_linear function to include input_k_dim, ensuring that DeepGEMM is only utilized when the input tensor's K dimension is properly aligned. This is particularly important for tensor parallelism scenarios, where input_size_per_partition might not always meet DeepGEMM's alignment requirements. The addition of clear comments and an updated docstring enhances code clarity and maintainability. Overall, this is a well-implemented fix that improves the robustness and correctness of the DeepGEMM integration.
|
Hi @KeeProMise, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
Signed-off-by: JianZhang <keepromise@apache.org>
Signed-off-by: JianZhang <keepromise@apache.org>
Signed-off-by: JianZhang <keepromise@apache.org>
|
Couple notes:
|
official recipe advises TP=8. Do you have a working version and the commit built against? |
yewentao256
left a comment
There was a problem hiding this comment.
Thanks for the work! Prefer this fix #30267
How about trying the latest version? |
|
I applied the fix on vllm 0.12.0 but still got the same error, do you know if there are other ways to resolve this? |
Please use the main branch, there is another fix for this merged to main. |
Purpose
see: #30206
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.