docs: update metrics design doc to use new vllm:kv_cache_usage_perc#30041
Merged
markmc merged 2 commits intovllm-project:mainfrom Dec 4, 2025
Merged
Conversation
|
Documentation preview: https://vllm--30041.org.readthedocs.build/en/30041/ |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates metric names in the docs/design/metrics.md file to improve clarity and consistency. The changes involve renaming vllm:time_per_output_token_seconds to vllm:inter_token_latency_seconds_bucket and vllm:gpu_cache_usage_perc to vllm:kv_cache_usage_perc within the Grafana Dashboard section. These modifications align the documented metric names with what is currently implemented in the codebase and used in other parts of the documentation, which is a positive improvement for documentation accuracy. The changes are correct and I have no further comments.
Signed-off-by: Tim <tim.wang03@sap.com>
haitwang-cloud
force-pushed
the
rename-gpu-cache-metric-deprecation
branch
from
ab9d454 to
696dc95
Compare
markmc
changed the title
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…llm-project#30041) Signed-off-by: Tim <tim.wang03@sap.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #18354, the
vllm:gpu_cache_usage_percmetric was deprecated andvllm:kv_cache_usage_percwas introduced as its replacement.See also #27133