SigLIP example add chat_template#29902
Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom Dec 3, 2025
Merged
Conversation
|
Documentation preview: https://vllm--29902.org.readthedocs.build/en/29902/ |
|
This pull request has merge conflicts that must be resolved before it can be |
4 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix the SigLIP example by adding a chat template. However, the chosen template template_basic.jinja is incorrect for this multimodal use case and will cause the server to error out when processing image inputs. I've provided a critical review comment with a detailed explanation and a suggestion for a correct template.
examples/online_serving/pooling/openai_chat_embedding_client_for_multimodal.py
Outdated
Show resolved
Hide resolved
examples/online_serving/pooling/openai_chat_embedding_client_for_multimodal.py
Outdated
Show resolved
Hide resolved
Member
|
Can you resolve the merge conflict? |
piood
requested review from
22quinn,
ApostaC,
LucasWilkinson,
WoosukKwon,
alexm-redhat,
gshtras,
heheda12345,
hmellor,
houseroad,
mgoin,
njhill,
noooop,
robertgshaw2-redhat,
sighingnow,
tjtanaa,
tlrmchlsmth,
yewentao256,
youkaichao and
ywang96
as code owners
DarkLight1337
approved these changes
Dec 3, 2025
DarkLight1337
removed
documentation
DarkLight1337
removed request for
22quinn,
ApostaC,
LucasWilkinson,
NickLucche,
ProExpertProg,
heheda12345,
hmellor,
houseroad,
mgoin,
njhill,
sighingnow,
tdoublep,
tjtanaa,
tlrmchlsmth,
youkaichao and
zou3519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
--chat-template pathwill auto check and redirect to build in chat-template when the path not found.--chat-template template_basic.jinjato use correct chat_template, update the example.