[ROCm][CI] Fix test_cudagraph_mode.py Failure For AMD CI#29808
Merged
gshtras merged 3 commits intovllm-project:mainfrom Dec 2, 2025
Merged
[ROCm][CI] Fix test_cudagraph_mode.py Failure For AMD CI#29808gshtras merged 3 commits intovllm-project:mainfrom
gshtras merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a CI failure on ROCm for test_cudagraph_mode.py by correcting the supported flag in test cases. The main improvement is the refactoring that removes duplicated code for ROCm and CUDA test configurations, replacing it with a unified setup. This not only fixes the immediate issue but also enhances maintainability and reduces the likelihood of similar bugs in the future. The change is clean, correct, and a good improvement to the test suite.
3 tasks
gshtras
approved these changes
Dec 2, 2025
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…t#29808) Signed-off-by: Micah Williamson <micah.williamson@amd.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #26847 was merged, we are seeing failures in AMD CI in the
v1/cudagraph/test_cudagraph_mode.pytest with errors likeDID NOT RAISE <class 'Exception'>.The problem was just that the
supportedfield was updated for the CUDA backend test but not the ROCm backend in thecombo_cases_2test case. Further, this happened because of a change I made last week in #29367 which introduced some code duplication that I have fixed here so that we can avoid these types of errors in the future.With this PR, I am again seeing the following when running
pytest -v -s v1/cudagraph/test_cudagraph_mode.py: