Fix some Transformers nightly tests#29802
Merged
Isotr0py merged 2 commits intovllm-project:mainfrom Dec 2, 2025
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Isotr0py
approved these changes
Dec 2, 2025
github-actions
bot
added
the
ready
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qwen2_5_VLForConditionalGeneration,Qwen2VLForConditionalGeneration,JinaVLForRanking- Uses Qwen 2/2.5 VL which recently had the hacky__getattribute__removed in Let's break Qwen-VL 🚨 huggingface/transformers#42420. This means that you cannot just get config fields from the root config and expect them to get fetched from the text configModernBertModel,ModernBertForTokenClassification,ModernBertForSequenceClassification- Instantiated its RoPE layer in a weird way. It now uses theget_ropemethod and uses thelayer_typesfield which is now present in Transformers v5