Use helper function instead of looping through attribute names#29788
Merged
hmellor merged 3 commits intovllm-project:mainfrom Dec 23, 2025
Merged
Use helper function instead of looping through attribute names#29788hmellor merged 3 commits intovllm-project:mainfrom
hmellor merged 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to refactor attribute access to use a helper function for consistency. While the change in get_inputs_embeds_size is correct, the change in get_total_num_kv_heads introduces a critical bug. The refactoring alters the logic for finding the number of KV heads. The original code correctly skipped attributes that were present but None, while the new implementation with getattr_iter will return None if it's the value of the first attribute found. This can lead to a TypeError downstream. I've left a specific comment with a suggested fix.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Member
Author
|
@ProExpertProg should be good now |
ProExpertProg
approved these changes
Dec 23, 2025
github-actions
bot
added
the
ready
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…project#29788) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
charlotte12l
added a commit
to charlotte12l/vllm
that referenced
this pull request
Dec 24, 2025
Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
yiliu30
pushed a commit
to yiliu30/vllm-fork
that referenced
this pull request
Dec 30, 2025
…project#29788) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…project#29788) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…project#29788) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have the helper function, it'd be better to use it so that the behaviour is consistent.