[ROCm][Bugfix] Patch for the Multi-Modal Processor Test group#29702
[ROCm][Bugfix] Patch for the Multi-Modal Processor Test group#29702DarkLight1337 merged 3 commits intovllm-project:mainfrom
Multi-Modal Processor Test group#29702Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Code Review
This pull request introduces fixes for the Multi-Modal Processor Test group on ROCm. The changes primarily involve updating Dockerfiles to include torchaudio and its dependencies, and restructuring the test requirements file. A specific workaround for AWQ quantization on ROCm is also added in the tests. My review focuses on improving maintainability and correctness. I've identified a duplicated COPY instruction in the Dockerfile.rocm and a duplicated dependency in requirements/rocm-test.txt. Addressing these will make the codebase cleaner and more robust.
docker/Dockerfile.rocm
Outdated
| # Copy in the v1 package | ||
| COPY vllm/v1 /usr/local/lib/python${PYTHON_VERSION}/dist-packages/vllm/v1 |
There was a problem hiding this comment.
This COPY instruction is duplicated from the test stage (line 100). To improve maintainability and avoid potential inconsistencies, consider centralizing this operation. A good approach would be to copy the vllm/v1 directory into an intermediate stage like export_vllm and then copy it from there into both the test and final stages. This would create a single source of truth for this artifact.
requirements/rocm-test.txt
Outdated
| multiprocess==0.70.16 | ||
| # Datasets and Evaluate Test |
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…-project#29702) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
…-project#29702) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
…-project#29702) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Purpose
Fix #29446
The
Multi-Modal Processor Testtest group was not passing on ROCm. This patch fixes any issues.Test Plan
Modify
<YOUR_HF_TOKEN>with your token (mostly for Llama model access).Test Result
On MI325: