Skip to content

[ROCm][Bugfix] Patch for the Multi-Modal Processor Test group#29702

Merged
DarkLight1337 merged 3 commits intovllm-project:mainfrom
ROCm:akaratza_multi_modal_proc_test
Nov 29, 2025
Merged

[ROCm][Bugfix] Patch for the Multi-Modal Processor Test group#29702
DarkLight1337 merged 3 commits intovllm-project:mainfrom
ROCm:akaratza_multi_modal_proc_test

Conversation

@AndreasKaratzas
Copy link
Copy Markdown
Collaborator

@AndreasKaratzas AndreasKaratzas commented Nov 28, 2025

Purpose

Fix #29446
The Multi-Modal Processor Test test group was not passing on ROCm. This patch fixes any issues.

Test Plan

docker build -f docker/Dockerfile.rocm_base -t rocm/vllm-dev:base . && docker build --no-cache -f docker/Dockerfile.rocm --target test -t vllm-rocm-test:latest .

docker run --rm -it --device /dev/kfd --device /dev/dri --network=host --shm-size=16gb --group-add video -w /vllm-workspace/tests -e HF_TOKEN=<YOUR_HF_TOKEN> -e PYTHONPATH=/vllm-workspace:$PYTHONPATH -e VLLM_WORKER_MULTIPROC_METHOD=spawn vllm-rocm-test:latest bash -c "pip install git+https://github.com/TIGER-AI-Lab/Mantis.git && pytest -v -s models/multimodal/processing"

Modify <YOUR_HF_TOKEN> with your token (mostly for Llama model access).

Test Result

On MI325:

538 passed, 289 skipped, 952 warnings in 2928.28s (0:48:48) 

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify bot added ci/build multi-modality Related to multi-modality (#4194) rocm Related to AMD ROCm labels Nov 28, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces fixes for the Multi-Modal Processor Test group on ROCm. The changes primarily involve updating Dockerfiles to include torchaudio and its dependencies, and restructuring the test requirements file. A specific workaround for AWQ quantization on ROCm is also added in the tests. My review focuses on improving maintainability and correctness. I've identified a duplicated COPY instruction in the Dockerfile.rocm and a duplicated dependency in requirements/rocm-test.txt. Addressing these will make the codebase cleaner and more robust.

Comment on lines +131 to +132
# Copy in the v1 package
COPY vllm/v1 /usr/local/lib/python${PYTHON_VERSION}/dist-packages/vllm/v1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This COPY instruction is duplicated from the test stage (line 100). To improve maintainability and avoid potential inconsistencies, consider centralizing this operation. A good approach would be to copy the vllm/v1 directory into an intermediate stage like export_vllm and then copy it from there into both the test and final stages. This would create a single source of truth for this artifact.

Comment on lines +72 to +73
multiprocess==0.70.16
# Datasets and Evaluate Test
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The multiprocess dependency is already specified on line 63. This duplicate entry should be removed to keep the requirements file clean and avoid potential conflicts.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 28, 2025 23:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 28, 2025
@DarkLight1337 DarkLight1337 merged commit ea3370b into vllm-project:main Nov 29, 2025
20 checks passed
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
amd-hhashemi pushed a commit to amd-hhashemi/vllm that referenced this pull request Dec 2, 2025
…-project#29702)

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
@AndreasKaratzas AndreasKaratzas deleted the akaratza_multi_modal_proc_test branch January 5, 2026 16:01
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…-project#29702)

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure]: mi325_1: Multi-Modal Processor Test

2 participants