Remove all_special_tokens_extended from tokenizer code#29686
Remove all_special_tokens_extended from tokenizer code#29686DarkLight1337 merged 1 commit intovllm-project:mainfrom
all_special_tokens_extended from tokenizer code#29686Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
4449139 to
56f2482
Compare
💡 Codex Reviewhttps://github.com/vllm-project/vllm/blob/44491395c266dc41b892fd8a98f25fa50b83d7ee/vllm/transformers_utils/config.py#L460-L461 In ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
DarkLight1337
left a comment
There was a problem hiding this comment.
I was planning on removing it as well since it's unused in vLLM, thanks for doing it!
|
I've enabled the Transformers nightly tests to verify that the errors relating to this attr are gone https://buildkite.com/vllm/ci/builds/41093/steps/canvas?sid=019acb27-ad2f-4514-ab1e-68141500585c |
There was a problem hiding this comment.
Code Review
This pull request correctly removes the all_special_tokens_extended attribute, which simplifies the tokenizer-related code and improves forward compatibility with Transformers v5. The changes are applied consistently across tests and implementations. However, the pull request also includes undocumented changes to RoPE parameter handling in vllm/transformers_utils/config.py and vllm/transformers_utils/configs/qwen3_next.py. Specifically, a block of code for Transformers v5 compatibility has been commented out. While this might be intentional, leaving commented-out code reduces maintainability. I've added a suggestion to remove it. It would be beneficial to update the pull request description to cover all changes for better clarity.
…t#29686) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…t#29686) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
…t#29686) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This attribute is:
all_special_tokensShould resolve the failures in https://buildkite.com/vllm/ci/builds/41020/steps/canvas?sid=019ac943-dca1-43d6-ad64-ca0187f645bc