Skip to content

[mypy] Enable type checking for more directories#29674

Merged
vllm-bot merged 5 commits intovllm-project:mainfrom
DarkLight1337:more-mypy
Nov 28, 2025
Merged

[mypy] Enable type checking for more directories#29674
vllm-bot merged 5 commits intovllm-project:mainfrom
DarkLight1337:more-mypy

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Nov 28, 2025

Purpose

Run full mypy check and make them pass against the following directories:

  • vllm/engine (except arg_utils.py)
  • vllm/plugins
  • vllm/worker
  • vllm/v1/metrics
  • vllm/v1/sample

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 28, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables mypy type checking for several new directories (vllm/engine, vllm/plugins, vllm/worker, vllm/v1/sample) by updating the pre-commit configuration. The associated changes are fixes to type annotations to make the code compliant with the stricter checks, such as allowing None for certain parameters and using TYPE_CHECKING for optional imports. The changes are correct and improve the overall type safety of the codebase. I have no further comments.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Copy Markdown
Member Author

Pre-commit passes now

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 28, 2025 14:41
@DarkLight1337
Copy link
Copy Markdown
Member Author

Flaky test

@vllm-bot vllm-bot merged commit 9e6bcda into vllm-project:main Nov 28, 2025
52 of 54 checks passed
@DarkLight1337 DarkLight1337 deleted the more-mypy branch November 28, 2025 16:39
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
amd-hhashemi pushed a commit to amd-hhashemi/vllm that referenced this pull request Dec 2, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build kv-connector ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants