[mypy] Enable type checking for more directories#29674
Merged
vllm-bot merged 5 commits intovllm-project:mainfrom Nov 28, 2025
Merged
[mypy] Enable type checking for more directories#29674vllm-bot merged 5 commits intovllm-project:mainfrom
vllm-bot merged 5 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables mypy type checking for several new directories (vllm/engine, vllm/plugins, vllm/worker, vllm/v1/sample) by updating the pre-commit configuration. The associated changes are fixes to type annotations to make the code compliant with the stricter checks, such as allowing None for certain parameters and using TYPE_CHECKING for optional imports. The changes are correct and improve the overall type safety of the codebase. I have no further comments.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Member
Author
|
Pre-commit passes now |
Isotr0py
approved these changes
Nov 28, 2025
Member
Author
|
Flaky test |
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
19 tasks
amd-hhashemi
pushed a commit
to amd-hhashemi/vllm
that referenced
this pull request
Dec 2, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Run full
mypycheck and make them pass against the following directories:vllm/engine(exceptarg_utils.py)vllm/pluginsvllm/workervllm/v1/metricsvllm/v1/sampleTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.