[Misc][Refactor] Decouple quant methods from FusedMoE#29505
Closed
bnellnm wants to merge 4 commits intovllm-project:mainfrom
Closed
[Misc][Refactor] Decouple quant methods from FusedMoE#29505bnellnm wants to merge 4 commits intovllm-project:mainfrom
bnellnm wants to merge 4 commits intovllm-project:mainfrom
Conversation
692a3b6 to
6ef5ced
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
6ef5ced to
af09b94
Compare
Collaborator
|
generally looks like its on the right track - I think the next step would be to then move the router outside of the fused moe class and call it directly |
Collaborator
|
but lets do that in the follow up. the flashinfer case (with the fused router) is not ideal |
af09b94 to
ce77dee
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
ce77dee to
e9605d2
Compare
Collaborator
Author
Yeah, that makes it a bit more awkward. |
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Depends on #30519
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.