Skip to content

[BugFix] Add sleep to fix tight loop and release GIL #29476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njhill merged 3 commits into from
Dec 18, 2025
Merged

[BugFix] Add sleep to fix tight loop and release GIL #29476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf07ad6
add sleep to fix tight loop and release GIL
alec-flowers Nov 26, 2025
f66be46
Update vllm/v1/engine/core.py
alec-flowers Dec 17, 2025
9107dce
Merge branch 'main' into fix-tight-loop
njhill Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions vllm/v1/engine/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,6 +895,13 @@ def _process_engine_step(self) -> bool:
# Post-step hook.
self.post_step(model_executed)

# If no model execution happened but there are waiting requests
# (e.g., WAITING_FOR_REMOTE_KVS), yield the GIL briefly to allow
# background threads (like NIXL handshake) to make progress.
# Without this, the tight polling loop can starve background threads.
if not model_executed and self.scheduler.has_requests():
Comment thread
alec-flowers marked this conversation as resolved.
Outdated
time.sleep(0.001)

return model_executed

def _handle_client_request(
Expand Down
Loading