Make Transformers Nightly tests soft-fail and enable all tests#29401
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Nov 25, 2025
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the 'Transformers Nightly Models Test' in the Buildkite pipeline. The changes include setting the job to soft_fail: true to prevent it from blocking the main branch, and enabling a wider range of tests by removing a pytest -k filter and uncommenting a test suite. These modifications are well-aligned with the stated goal of increasing test coverage against the Transformers main branch in a non-blocking manner. The implementation is correct and I have no concerns.
DarkLight1337
approved these changes
Nov 25, 2025
github-actions
bot
added
the
ready
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…project#29401) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…project#29401) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…project#29401) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting these tests to soft fail because they should not make vLLM's main branch to go red.
These tests are a smoke test to help us find problems with vLLM/Transformers on the Transformers main branch. This enables us to make fixes in vLLM/Transformers ahead of Transformers releases which smooths the process of updating Transformers version in vLLM.