[Bugfix] [ROCm] [UX]: revert Flex attention backend#29371
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Nov 25, 2025
Merged
[Bugfix] [ROCm] [UX]: revert Flex attention backend#29371DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Contributor
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly restores the selection logic for the FLEX_ATTENTION backend, which was accidentally removed. The change in vllm/platforms/rocm.py re-introduces the necessary check. Additionally, a new unit test has been added in tests/v1/attention/test_rocm_attention_backends_selection.py to ensure this backend can be selected, which is a good practice to prevent future regressions. The changes are correct and well-contained.
Contributor
Author
|
Hi @tjtanaa , I fixed this, pls review the code when you have time. Thanks! |
DarkLight1337
approved these changes
Nov 25, 2025
github-actions
bot
added
the
ready
5 tasks
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description This PR restores the FLEX_ATTENTION backend selection logic that was accidentally removed in PR #26980.
Changes
Re-added explicit check for AttentionBackendEnum.FLEX_ATTENTION in vllm/platforms/rocm.py.
Added a corresponding unit test case in tests/v1/attention/test_rocm_attention_backends_selection.py to ensure it is correctly selected.