Skip to content

Fix PoolingParams.skip_reading_prefix_cache type #29364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noooop merged 1 commit into from
Nov 25, 2025
Merged

Fix PoolingParams.skip_reading_prefix_cache type #29364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/pooling_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class PoolingParams(
## Internal use only
task: PoolingTask | None = None
requires_token_ids: bool = False
skip_reading_prefix_cache: bool = None
skip_reading_prefix_cache: bool | None = None
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This correctly fixes the type annotation for skip_reading_prefix_cache. However, a similar issue exists in vllm/sampling_params.py on line 257, where skip_reading_prefix_cache: bool = None will also cause a msgspec.ValidationError. To ensure a complete fix, please update the type annotation in SamplingParams as well.

extra_kwargs: dict[str, Any] | None = None
output_kind: RequestOutputKind = RequestOutputKind.FINAL_ONLY

Expand Down
2 changes: 1 addition & 1 deletion vllm/sampling_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class SamplingParams(
generated token can complete the sequence."""
_bad_words_token_ids: list[list[int]] | None = None

skip_reading_prefix_cache: bool = None
skip_reading_prefix_cache: bool | None = None

@staticmethod
def from_optional(
Expand Down