Skip to content

Fix RoPE related failures in Transformers nightly tests #29333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmellor merged 5 commits into from
Nov 25, 2025
Merged

Fix RoPE related failures in Transformers nightly tests #29333

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37f1ec3
Fix Transformers nightly
hmellor Nov 24, 2025
cafcf4b
original_max_position_embeddings needs patching for v5 too
hmellor Nov 25, 2025
7db03ff
Refactor rope_parameters patching
hmellor Nov 25, 2025
9486632
Allow `type` and `rope_type` to differ if they mean the same thing
hmellor Nov 25, 2025
eabb50c
Fix models where `config.rope_parameters` are not always present
hmellor Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion vllm/transformers_utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,20 +452,25 @@ def set_default_rope_theta(config: PretrainedConfig, default_theta: float) -> No

def patch_rope_parameters(config: PretrainedConfig) -> None:
"""Provide backwards compatibility for RoPE."""
# rope_theta may exist in custom models written for Transformers v4
rope_theta: float | None = getattr(config, "rope_theta", None)
# Retrieve rope_parameters differently based on Transformers version
if Version(version("transformers")) >= Version("5.0.0.dev0"):
from transformers.modeling_rope_utils import RopeParameters

rope_parameters: RopeParameters | dict[str, RopeParameters] | None = getattr(
config, "rope_parameters", None
)
# If rope_theta exists, move it into rope_parameters
if rope_parameters is not None and rope_theta is not None:
rope_parameters["rope_theta"] = rope_theta
Comment thread
hmellor marked this conversation as resolved.
Outdated
del config.rope_theta
Comment thread
hmellor marked this conversation as resolved.
Outdated
elif hasattr(config, "rope_parameters"):
# We are in Transformers v4 and rope_parameters
# has already been patched for this config
return
else:
# Convert Transformers v4 rope_theta and rope_scaling into rope_parameters
rope_theta: float | None = getattr(config, "rope_theta", None)
rope_scaling: dict | None = getattr(config, "rope_scaling", None)
rope_parameters = rope_scaling
# Move rope_theta into rope_parameters
Expand Down
Loading