[CI Failure] Fix Gemma3 RoPE configuration for sliding attention layers#29111
Merged
vllm-bot merged 3 commits intovllm-project:mainfrom Nov 21, 2025
Merged
[CI Failure] Fix Gemma3 RoPE configuration for sliding attention layers#29111vllm-bot merged 3 commits intovllm-project:mainfrom
vllm-bot merged 3 commits intovllm-project:mainfrom
Conversation
hmellor
reviewed
Nov 20, 2025
hmellor
reviewed
Nov 20, 2025
Signed-off-by: Huamin Li <3ericli@gmail.com>
hl475
force-pushed
the
fix_gemma3_attention
branch
from
c5a6b15 to
074c4f9
Compare
Contributor
Author
|
Thanks @hmellor ! Love your suggestion and I think it is more clean! Please take another look! |
hmellor
reviewed
Nov 20, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
github-actions
bot
added
the
ready
Member
|
Failing Plamo3 test is failing on main and should be fixed by #29092 |
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Nov 23, 2025
…rs (vllm-project#29111) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
PatchouliTIS
pushed a commit
to PatchouliTIS/vllm
that referenced
this pull request
Nov 24, 2025
…rs (vllm-project#29111) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: PatchouliTaisa <patchychen@tencent.com>
lpapavassiliou
pushed a commit
to lpapavassiliou/vllm
that referenced
this pull request
Nov 24, 2025
…rs (vllm-project#29111) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
RunkaiTao
pushed a commit
to RunkaiTao/vllm
that referenced
this pull request
Nov 24, 2025
…rs (vllm-project#29111) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: Runkai Tao <rt572@physics.rutgers.edu>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…rs (vllm-project#29111) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…rs (vllm-project#29111) Signed-off-by: Huamin Li <3ericli@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#28542 introduced a regression in Gemma3 model that caused incorrect perplexity scores. The test test_gemma.py::test_ppl[model_info2] failed https://buildkite.com/vllm/ci/builds/39860/steps/table?jid=019aa011-0d25-4a55-9e34-b7caef1ee9df . Per investigation, we should use default RoPE with rope_local_base_freq (10000.0) and NO scaling
if self.is_slidingThis PR changes
if self.is_slidingbranch to properly configure sliding attention layers.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.