[V0 Deprecation] Remove best_of#29090
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Nov 21, 2025
Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
DarkLight1337
requested review from
aarnphm and
chaunceyjiang
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated best_of sampling parameter. The changes are comprehensive, touching upon the SamplingParams definition, the OpenAI-compatible API protocols, the serving logic, and associated tests. The removal of best_of and its related logic, such as _real_n and various validation checks, simplifies the codebase and aligns with the goal of deprecating V0 features. The modifications are well-executed and I have no further comments.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Documentation preview: https://vllm--29090.org.readthedocs.build/en/29090/ |
hmellor
approved these changes
Nov 20, 2025
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Nov 23, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
lpapavassiliou
pushed a commit
to lpapavassiliou/vllm
that referenced
this pull request
Nov 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
RunkaiTao
pushed a commit
to RunkaiTao/vllm
that referenced
this pull request
Nov 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Runkai Tao <rt572@physics.rutgers.edu>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Accoreding to #13997,
best_ofis not intended to stay in V1 so let's remove the associated code now that V0 is gone.Related to #27984
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.