Skip to content

[Async Scheduling] Support async scheduling with ray backend#29012

Open
lhtin wants to merge 8 commits intovllm-project:mainfrom
lhtin:feature/support-async-scheduling-with-ray
Open

[Async Scheduling] Support async scheduling with ray backend#29012
lhtin wants to merge 8 commits intovllm-project:mainfrom
lhtin:feature/support-async-scheduling-with-ray

Conversation

@lhtin
Copy link
Contributor

@lhtin lhtin commented Nov 19, 2025

Support enabling async-scheduling when using Ray as distributed_executor_backend (i.e., fixing the issues left by this PR #25887).

Timeline:

Clipboard_Screenshot_1766565947

cc @benchislett

@mergify mergify bot added the v1 label Nov 19, 2025
@lhtin lhtin force-pushed the feature/support-async-scheduling-with-ray branch from 0e81898 to 9f9ac3a Compare November 19, 2025 13:23
@lhtin lhtin marked this pull request as ready for review November 24, 2025 08:11
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Collaborator

@ruisearch42 ruisearch42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@lhtin lhtin force-pushed the feature/support-async-scheduling-with-ray branch from e9e5c6b to 70508ec Compare November 26, 2025 04:14
Copy link
Collaborator

@benchislett benchislett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we have unit tests covering this feature combination?

@lhtin
Copy link
Contributor Author

lhtin commented Dec 5, 2025

Looks good. Do we have unit tests covering this feature combination?

Thanks for your review. I add some e2e tests in test_async_scheduling.py.

@lhtin lhtin changed the title Support async scheduling with ray backend [WIP] Support async scheduling with ray backend Dec 23, 2025
@lhtin lhtin force-pushed the feature/support-async-scheduling-with-ray branch from f2a705d to e591fc1 Compare December 24, 2025 09:08
@lhtin lhtin changed the title [WIP] Support async scheduling with ray backend [Async Scheduling] Support async scheduling with ray backend Dec 24, 2025
@lhtin
Copy link
Contributor Author

lhtin commented Dec 24, 2025

@benchislett @ruisearch42 Hello, I've updated the code and uploaded a screenshot of the Timeline effect. Could you please help review it again? Thanks!

@mergify
Copy link

mergify bot commented Dec 24, 2025

Hi @lhtin, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

@lhtin lhtin force-pushed the feature/support-async-scheduling-with-ray branch from e591fc1 to 3781280 Compare December 29, 2025 06:51
@mergify
Copy link

mergify bot commented Dec 29, 2025

Hi @lhtin, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

1 similar comment
@mergify
Copy link

mergify bot commented Dec 29, 2025

Hi @lhtin, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

@mergify
Copy link

mergify bot commented Dec 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @lhtin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 30, 2025
Signed-off-by: Lehua Ding <lehuading@tencent.com>
@lhtin lhtin force-pushed the feature/support-async-scheduling-with-ray branch from 6f17c6d to 1518b77 Compare December 30, 2025 02:57
@mergify mergify bot removed the needs-rebase label Dec 30, 2025
@lhtin lhtin mentioned this pull request Dec 30, 2025
22 tasks
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lhtin.

TBH I haven't wrapped my head around the logic here, would be good to get a final review from @ruisearch42 and @Lumosis

lhtin and others added 3 commits December 31, 2025 11:29
Co-authored-by: Nick Hill <nick@inferact.ai>
Signed-off-by: Lehua Ding <lehuading@qq.com>
Signed-off-by: Lehua Ding <lehuading@tencent.com>
Signed-off-by: Lehua Ding <lehuading@tencent.com>
@lhtin
Copy link
Contributor Author

lhtin commented Jan 27, 2026

Ping again, thanks. @benchislett

Signed-off-by: Lehua Ding <lehuading@tencent.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

@mergify
Copy link

mergify bot commented Jan 30, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @lhtin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 30, 2026
@Lumosis
Copy link
Contributor

Lumosis commented Feb 5, 2026

Hi @mgoin @robertgshaw2-redhat @simon-mo! Could you take a look at this PR? This is blocking TPU multi-host optimization as well. Thanks!

Signed-off-by: Lehua Ding <lehuading@tencent.com>
@mergify mergify bot removed the needs-rebase label Feb 6, 2026
Signed-off-by: Lehua Ding <lehuading@tencent.com>
@Lumosis
Copy link
Contributor

Lumosis commented Feb 10, 2026

Hi @yaochengji, could you also take a look when you get a chance?

@devdev999
Copy link

Will this get any reviews?

@eugenepaniot
Copy link

wating for this!

Signed-off-by: Lehua Ding <lehuading@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants