[Async Scheduling] Support async scheduling with ray backend#29012
[Async Scheduling] Support async scheduling with ray backend#29012lhtin wants to merge 8 commits intovllm-project:mainfrom
Conversation
0e81898 to
9f9ac3a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
e9e5c6b to
70508ec
Compare
benchislett
left a comment
There was a problem hiding this comment.
Looks good. Do we have unit tests covering this feature combination?
Thanks for your review. I add some e2e tests in test_async_scheduling.py. |
f2a705d to
e591fc1
Compare
|
@benchislett @ruisearch42 Hello, I've updated the code and uploaded a screenshot of the Timeline effect. Could you please help review it again? Thanks! |
|
Hi @lhtin, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
e591fc1 to
3781280
Compare
|
Hi @lhtin, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
1 similar comment
|
Hi @lhtin, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Lehua Ding <lehuading@tencent.com>
6f17c6d to
1518b77
Compare
njhill
left a comment
There was a problem hiding this comment.
Thanks @lhtin.
TBH I haven't wrapped my head around the logic here, would be good to get a final review from @ruisearch42 and @Lumosis
Co-authored-by: Nick Hill <nick@inferact.ai> Signed-off-by: Lehua Ding <lehuading@qq.com>
Signed-off-by: Lehua Ding <lehuading@tencent.com>
Signed-off-by: Lehua Ding <lehuading@tencent.com>
|
Ping again, thanks. @benchislett |
Signed-off-by: Lehua Ding <lehuading@tencent.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
|
This pull request has merge conflicts that must be resolved before it can be |
|
Hi @mgoin @robertgshaw2-redhat @simon-mo! Could you take a look at this PR? This is blocking TPU multi-host optimization as well. Thanks! |
Signed-off-by: Lehua Ding <lehuading@tencent.com>
Signed-off-by: Lehua Ding <lehuading@tencent.com>
|
Hi @yaochengji, could you also take a look when you get a chance? |
|
Will this get any reviews? |
|
wating for this! |
Signed-off-by: Lehua Ding <lehuading@tencent.com>
Support enabling async-scheduling when using Ray as distributed_executor_backend (i.e., fixing the issues left by this PR #25887).
Timeline:
cc @benchislett