[Misc] Add backup hash algorithm for FIPS constrained environments#28795
[Misc] Add backup hash algorithm for FIPS constrained environments#28795russellb merged 32 commits intovllm-project:mainfrom
Conversation
Signed-off-by: George D. Torres <gdavtor@gmail.com>
Signed-off-by: George D. Torres <gdavtor@gmail.com>
Signed-off-by: George D. Torres <41129492+geodavic@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a safe_hash utility to provide a fallback hashing mechanism for FIPS-constrained environments where md5 is disabled. The changes correctly replace hashlib.md5 with safe_hash across the codebase, ensuring that sha256 is used as a fallback. My review focuses on the implementation of safe_hash and its usage. I've identified one area for improvement in the safe_hash implementation to ensure consistency in parameter passing. Overall, this is a good change that improves compatibility in secure environments.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: George D. Torres <gdavtor@gmail.com>
Signed-off-by: George D. Torres <41129492+geodavic@users.noreply.github.com>
|
CC @russellb |
|
I meant that it was not using |
|
Docs failure is relevant |
Signed-off-by: George D. Torres <gdavtor@gmail.com>
|
@hmellor thanks! |
|
@russellb can I get one more stamp? Should go through now (finally) |
Signed-off-by: Russell Bryant <rbryant@redhat.com>
…llm-project#28795) Signed-off-by: George D. Torres <gdavtor@gmail.com> Signed-off-by: George D. Torres <41129492+geodavic@users.noreply.github.com> Signed-off-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Russell Bryant <rbryant@redhat.com>
…llm-project#28795) Signed-off-by: George D. Torres <gdavtor@gmail.com> Signed-off-by: George D. Torres <41129492+geodavic@users.noreply.github.com> Signed-off-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
There are many places where
hashlib.md5is used to compute hashes in configs. This algorithm isn't Federal Information Processing Standards (FIPS) compliant, and so the vLLM engine will fail to start inside environments wheremd5is forcefully disabled.Purpose
Add a backup hashing algorithm for environments where
hashlib.md5is disabled. These changes will still usemd5when it is available, ensuring no existing behavior is changed. But when it is not available, it will fall back to a FIPS compliant algorithm (sha256).Test Plan
I spun up a server locally and performed inference
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.