Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Nov 15, 2025

Build broken by #27126 due to & in buildkite pipeline step name.

Not sure why this wasn't hit in the CI which ran on the PR.

Signed-off-by: Nick Hill <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a broken CI pipeline by replacing the ampersand character (&) with and in a step label within the .buildkite/test-pipeline.yaml file. The use of & can cause parsing issues in YAML, so this change is correct and necessary. The fix is straightforward and directly addresses the problem. The code looks good to merge.

@mergify mergify bot added the ci/build label Nov 15, 2025
Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks!

@ProExpertProg ProExpertProg enabled auto-merge (squash) November 15, 2025 16:42
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 15, 2025
@vllm-bot vllm-bot merged commit 637f292 into vllm-project:main Nov 15, 2025
10 of 15 checks passed
@njhill njhill deleted the fix-step-name branch November 15, 2025 16:44
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: George D. Torres <[email protected]>
bwasti pushed a commit to bwasti/vllm that referenced this pull request Nov 17, 2025
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Bram Wasti <[email protected]>
bringlein pushed a commit to bringlein/vllm that referenced this pull request Nov 26, 2025
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
charlotte12l pushed a commit to charlotte12l/vllm that referenced this pull request Dec 5, 2025
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Xingyu Liu <[email protected]>
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants