Skip to content

Fixed gpt-oss _load_weights_other() parameter position bug #28715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heheda12345 merged 1 commit into from
Nov 16, 2025
+1 −1
Merged

Fixed gpt-oss _load_weights_other() parameter position bug #28715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/model_executor/models/gpt_oss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,8 +641,8 @@ def load_weights(self, weights: Iterable[tuple[str, torch.Tensor]]) -> set[str]:
)
else:
return self._load_weights_other(
ep_rank_end,
ep_rank_start,
ep_rank_end,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly fixes the argument order, the root cause of the bug is the inconsistent parameter order between _load_weights_other and _load_weights_mxfp4. To improve readability and prevent similar bugs in the future, it's highly recommended to use keyword arguments for this call. This makes the code more explicit and robust against parameter reordering. For example:

return self._load_weights_other(
    ep_rank_start=ep_rank_start,
    ep_rank_end=ep_rank_end,
    heads_per_rank=heads_per_rank,
    head_start=head_start,
    weights=weights,
    stacked_params_mapping=stacked_params_mapping,
)

heads_per_rank,
head_start,
weights,
Expand Down