Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions tests/v1/core/test_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,8 @@ def test_kv_connector_basic(is_async: bool):
)


def test_external_prefix_cache_metrics():
@pytest.mark.parametrize("is_async", [False, True])
def test_external_prefix_cache_metrics(is_async: bool):
"""
Verify connector prefix cache metrics are updated
correctly when the scheduler processes requests with KV connector hits.
Expand All @@ -1067,7 +1068,9 @@ def test_external_prefix_cache_metrics():
NUM_MATCHED_NEW_TOKENS = 4
scheduler = create_scheduler(
enable_prefix_caching=False,
use_kv_connector=mock_kv(matched_tokens=NUM_MATCHED_NEW_TOKENS, is_async=False),
use_kv_connector=mock_kv(
matched_tokens=NUM_MATCHED_NEW_TOKENS, is_async=is_async
),
)

# --- Prepare simple requests ---
Expand All @@ -1079,9 +1082,15 @@ def test_external_prefix_cache_metrics():
num_tokens=NUM_TOKENS,
max_tokens=MAX_TOKENS,
)
req_ids = []
req_to_index = {}
for i, request in enumerate(requests):
scheduler.add_request(request)
req_ids.append(request.request_id)
req_to_index[request.request_id] = i

for req in requests:
scheduler.add_request(req)
if is_async:
_step_until_kv_transfer_finished(scheduler, req_ids)

# --- Trigger scheduling and simulate model output ---
output = scheduler.schedule()
Expand Down
16 changes: 8 additions & 8 deletions vllm/v1/core/sched/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ def schedule(self) -> SchedulerOutput:
skipped_waiting_requests.prepend_request(request)
continue

request.num_external_computed_tokens = ext_tokens
num_external_computed_tokens = ext_tokens

# Total computed tokens (local + external).
Expand Down Expand Up @@ -569,9 +570,6 @@ def schedule(self) -> SchedulerOutput:
new_computed_blocks + new_blocks,
num_external_computed_tokens,
)
self._update_connector_prefix_cache_stats(
request, num_external_computed_tokens
)

# Request was already popped from self.waiting
# unless it was re-added above due to new_blocks being None.
Expand All @@ -583,6 +581,8 @@ def schedule(self) -> SchedulerOutput:
request.status = RequestStatus.WAITING_FOR_REMOTE_KVS
continue

self._update_connector_prefix_cache_stats(request)

req_index += 1
self.running.append(request)
if self.log_stats:
Expand Down Expand Up @@ -1356,15 +1356,13 @@ def shutdown(self) -> None:
# KV Connector Related Methods
########################################################################

def _update_connector_prefix_cache_stats(
self, request: Request, num_external_tokens: int
) -> None:
def _update_connector_prefix_cache_stats(self, request: Request) -> None:
if self.connector_prefix_cache_stats is None:
return

self.connector_prefix_cache_stats.record(
num_tokens=request.num_tokens,
num_hits=num_external_tokens,
num_hits=request.num_external_computed_tokens,
preempted=request.num_preemptions > 0,
)

Expand Down Expand Up @@ -1547,9 +1545,11 @@ def _update_requests_with_invalid_blocks(
marked_invalid_block = True
# Truncate the computed tokens at the first failed block
request.num_computed_tokens = idx * self.block_size
total_affected_tokens += (
num_affected_tokens = (
req_num_computed_tokens - request.num_computed_tokens
)
total_affected_tokens += num_affected_tokens
request.num_external_computed_tokens -= num_affected_tokens

if is_affected:
if not marked_invalid_block:
Expand Down
3 changes: 3 additions & 0 deletions vllm/v1/request.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ def __init__(
# The number of requests being preempted by the scheduler
self.num_preemptions = 0

# The number of tokens that have been computed remotely.
self.num_external_computed_tokens = 0

self.block_hashes: list[BlockHash] = []
self.get_hash_new_full_blocks: Callable[[], list[BlockHash]] | None = None
if block_hasher is not None:
Expand Down