-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[Misc] fix typo in DCP comment #28389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a typo in a comment within vllm/v1/attention/backends/mla/common.py. The change is correct and improves code readability. I have reviewed the changes and found no high or critical issues to report.
|
@Livinfly can you fix the DCO failure with this guide? https://github.com/vllm-project/vllm/pull/28389/checks?check_run_id=54957388721 |
Head branch was pushed to by a user without write access
Signed-off-by: Livinfly <[email protected]>
@heheda12345 Apologies for the delay. The issue has been fixed. |
Signed-off-by: Livinfly <[email protected]>
Signed-off-by: Livinfly <[email protected]> Signed-off-by: George D. Torres <[email protected]>
Signed-off-by: Livinfly <[email protected]>
Signed-off-by: Livinfly <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Purpose
Test Plan
NA
Test Result
NA
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.