Skip to content

Conversation

@Livinfly
Copy link
Contributor

@Livinfly Livinfly commented Nov 10, 2025

Purpose

  1. fix typo

Test Plan

NA

Test Result

NA


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the v1 label Nov 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a typo in a comment within vllm/v1/attention/backends/mla/common.py. The change is correct and improves code readability. I have reviewed the changes and found no high or critical issues to report.

@heheda12345 heheda12345 changed the title [Misc] fix typo [Misc] fix typo in DCP comment Nov 11, 2025
@heheda12345 heheda12345 enabled auto-merge (squash) November 11, 2025 08:25
@heheda12345
Copy link
Collaborator

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 11, 2025
auto-merge was automatically disabled November 11, 2025 11:57

Head branch was pushed to by a user without write access

Signed-off-by: Livinfly <[email protected]>
@Livinfly
Copy link
Contributor Author

@Livinfly can you fix the DCO failure with this guide? https://github.com/vllm-project/vllm/pull/28389/checks?check_run_id=54957388721

@heheda12345 Apologies for the delay. The issue has been fixed.

@heheda12345 heheda12345 merged commit 8c32c6e into vllm-project:main Nov 11, 2025
49 checks passed
fangyuchu pushed a commit to fangyuchu/vllm that referenced this pull request Nov 12, 2025
@Livinfly Livinfly deleted the fix-typo branch November 12, 2025 04:08
geodavic pushed a commit to geodavic/vllm that referenced this pull request Nov 16, 2025
Signed-off-by: Livinfly <[email protected]>
Signed-off-by: George D. Torres <[email protected]>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
charlotte12l pushed a commit to charlotte12l/vllm that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants