Skip to content

[BugFix][CI/Build][ROCM] Fix import error and apply assert in appropriate case in test_struct_output_generate #28311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 14, 2025
Merged

[BugFix][CI/Build][ROCM] Fix import error and apply assert in appropriate case in test_struct_output_generate #28311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df97fd6
Fix import error and apply assert in appropriate case
Nov 7, 2025
87bc309
precommit check
Nov 7, 2025
b9639ef
Merge branch 'main' into ransmith_fix_27844
rasmith Nov 7, 2025
673f241
merge main
Nov 11, 2025
0fee5aa
fix typo
Nov 11, 2025
1fdb0a4
Merge branch 'main' into ransmith_fix_27844
rasmith Nov 13, 2025
338df55
use get_cu_count
Nov 13, 2025
e728613
merge main
Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/v1/entrypoints/llm/test_struct_output_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,14 @@ def test_structured_output_with_reasoning_matrices(
reasoning_content, content = run_reasoning_extraction(reasoner, [generated_text])
print(f"Prompt: {prompt!r}\nReasoning: {reasoning_content!r}\nContent: {content!r}")

assert content is not None and reasoning_content is not None
output_json = json.loads(content)
jsonschema.validate(instance=output_json, schema=reasoning_schema)
if "Qwen3" in model_name:
assert content is not None

assert reasoning_content is not None

if content is not None:
output_json = json.loads(content)
jsonschema.validate(instance=output_json, schema=reasoning_schema)


@pytest.mark.skip_global_cleanup
Expand Down
4 changes: 2 additions & 2 deletions vllm/v1/attention/backends/rocm_aiter_fa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
_CP_TOKENS_PER_ITER_ROCM = 32 * 1024

if current_platform.is_rocm():
import aiter
from aiter.ops.triton.utils.device_info import get_num_sms
from aiter.ops.triton.utils.arch_info import get_num_sms

import aiter
from vllm.triton_utils import tl, triton

def block_size(x, head_dim):
Expand Down
Loading