[Hybrid] [Kernel] Fix chunk scan kernel when BLOCK_SIZE_DSTATE > 128#28295
Merged
heheda12345 merged 2 commits intovllm-project:mainfrom Nov 14, 2025
Merged
[Hybrid] [Kernel] Fix chunk scan kernel when BLOCK_SIZE_DSTATE > 128#28295heheda12345 merged 2 commits intovllm-project:mainfrom
heheda12345 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a critical bug in the chunk scan kernel that caused compilation errors for models with BLOCK_SIZE_DSTATE > 128. The issue was a shape mismatch for the prev_states tensor between two conditional branches within the kernel, leading to a Triton compiler AssertionError. The fix correctly aligns the tensor shapes by changing the dimensions passed to tl.zeros, which resolves the error. The change is precise and effectively solves the described problem. The pull request is well-documented with a clear explanation of the bug and validation through test results. The fix is correct and looks good to merge.
heheda12345
approved these changes
Nov 11, 2025
geodavic
pushed a commit
to geodavic/vllm
that referenced
this pull request
Nov 16, 2025
…llm-project#28295) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…llm-project#28295) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
kitaekatt
pushed a commit
to kitaekatt/vllm
that referenced
this pull request
Dec 1, 2025
…llm-project#28295) Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Falcon-H1 models are failing on main due to a bug in the chunk scan kernel introduced by #24683 for models that use BLOCK_SIZE_DSTATE > 128.
The error looks like:
Test Plan
Test Result
Using v0.10.2 (before bug was introduced)
After this PR:
Results are matching within stderr.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.