[[V0 deprecation]]Remove VLLM_USE_V1 env#28204
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Code Review
This pull request completes the removal of the deprecated VLLM_USE_V1 environment variable as part of the V0 deprecation. The changes are straightforward, correctly removing the variable's definition, its usage in tests, and its collection for usage statistics. The modifications are consistent and self-contained. I have reviewed the changes and found no issues of high or critical severity.
5af2a71 to
8c18d5b
Compare
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Head branch was pushed to by a user without write access
8c18d5b to
7790485
Compare
|
Documentation preview: https://vllm--28204.org.readthedocs.build/en/28204/ |
|
@DarkLight1337 For example part, I left |
|
@DarkLight1337 CI failure looks doesn't relate to this change. |
|
Retrying flaky test |
There was a problem hiding this comment.
It seems we should delete this example rather than allowing it to continue on, if V0 is required cc @ywang96
There was a problem hiding this comment.
Ditto, we should delete the example if it doesn't work on V1
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: George D. Torres <gdavtor@gmail.com>
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Purpose
This is the last PR to remove VLLM_USE_V1 env totally. Currently, there is no place to use this env and is safe to remote it.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.