[CI] Add compile/test_multimodal_compile.py to CI#28151
[CI] Add compile/test_multimodal_compile.py to CI#28151Isotr0py merged 2 commits intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the test_multimodal_compile.py test to the CI pipeline. However, I've found a critical issue: the new test requires a GPU but doesn't check for its availability. Since other tests in the same CI step have checks for GPUs, it's possible this step could run on a CPU-only machine, which would cause the build to fail. My review comment on the pipeline configuration change details how to fix this in the test file to ensure CI stability.
|
@zou3519 Please take a look. CC @Lucaskabela as you recently added the test |
There was a problem hiding this comment.
Code Review
This pull request adds a new multimodal model compilation test to the CI pipeline. The change is straightforward, but to enhance the CI's stability, I've suggested adding a timeout to the new test command. This will mitigate the risk of the test hanging, which can occur when loading and compiling large models, and prevent it from blocking the entire CI job.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Signed-off-by: Yanan Cao <gmagogsfm@gmail.com>
gmagogsfm
force-pushed
the
add_qwen_ci
branch
from
e0d4209 to
30d2d86
Compare
github-actions
bot
added
the
ready
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Yanan Cao <gmagogsfm@gmail.com> Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
2 participants
Signed off by: Yanan Cao gmagogsfm@gmail.com