[V0 deprecation]clean up is_v1_supported_oracle#28116
Merged
Isotr0py merged 1 commit intovllm-project:mainfrom Nov 6, 2025
Merged
[V0 deprecation]clean up is_v1_supported_oracle#28116Isotr0py merged 1 commit intovllm-project:mainfrom
Isotr0py merged 1 commit intovllm-project:mainfrom
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the engine argument handling to remove the fallback to the V0 engine, which is being deprecated. Instead of falling back, the code now raises a NotImplementedError for unsupported features, making the behavior more explicit and simplifying the codebase. The changes are mainly in vllm/engine/arg_utils.py and the corresponding tests are updated in tests/v1/test_oracle.py. The implementation is sound, but I've found a minor bug in an error message formatting that results in an incomplete message being shown to the user.
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
auto-merge was automatically disabled
November 6, 2025 01:02
Head branch was pushed to by a user without write access
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Clean up _is_v1_supported_oracle. Let' raise
NotImplementedErrorfor unsupported feature directly.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.