Skip to content

[V0 deprecation]clean up is_v1_supported_oracle#28116

Merged
Isotr0py merged 1 commit intovllm-project:mainfrom
wangxiyuan:remove_v1
Nov 6, 2025
Merged

[V0 deprecation]clean up is_v1_supported_oracle#28116
Isotr0py merged 1 commit intovllm-project:mainfrom
wangxiyuan:remove_v1

Conversation

@wangxiyuan
Copy link
Copy Markdown
Contributor

@wangxiyuan wangxiyuan commented Nov 5, 2025

Purpose

Clean up _is_v1_supported_oracle. Let' raise NotImplementedError for unsupported feature directly.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the engine argument handling to remove the fallback to the V0 engine, which is being deprecated. Instead of falling back, the code now raises a NotImplementedError for unsupported features, making the behavior more explicit and simplifying the codebase. The changes are mainly in vllm/engine/arg_utils.py and the corresponding tests are updated in tests/v1/test_oracle.py. The implementation is sound, but I've found a minor bug in an error message formatting that results in an incomplete message being shown to the user.

Copy link
Copy Markdown
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Isotr0py Isotr0py enabled auto-merge (squash) November 5, 2025 14:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
auto-merge was automatically disabled November 6, 2025 01:02

Head branch was pushed to by a user without write access

@Isotr0py Isotr0py merged commit c3ee80a into vllm-project:main Nov 6, 2025
48 checks passed
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants