[Misc] Remove the duplicate code#28111
Merged
aarnphm merged 1 commit intovllm-project:mainfrom Nov 6, 2025
Merged
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes a redundant block of code from _construct_input_messages_with_harmony. The removed code, which converted a dict to a ResponseFunctionToolCall object, is now handled by the function_call_parsing model validator in the ResponsesRequest class. This change is a good cleanup that improves maintainability by eliminating duplicated logic. The change is correct and I have no further suggestions.
aarnphm
approved these changes
Nov 6, 2025
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When implementing #24317, #26706 had not yet been merged. Now that #26706 is merged, this piece of code is no longer needed.
Test Plan
A complete end-to-end test was written in #24317, which can verify that the functionality remains correct after removing this code.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.