Remove deprecated --rope-scaling and --rope-theta#28006
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Nov 4, 2025
Merged
Remove deprecated --rope-scaling and --rope-theta#28006DarkLight1337 merged 2 commits intovllm-project:mainfrom
--rope-scaling and --rope-theta#28006DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
These have been deprecated for a year so we should remove them. Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively removes the deprecated --rope-scaling and --rope-theta arguments. The changes are applied consistently across vllm/config/model.py and vllm/engine/arg_utils.py, removing the configuration fields, command-line argument parsing, and associated logic. The cleanup is thorough and aligns with the goal of removing deprecated functionality. The code is now cleaner and ready for future RoPE configuration enhancements.
DarkLight1337
approved these changes
Nov 4, 2025
github-actions
bot
added
the
ready
yewentao256
approved these changes
Nov 4, 2025
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…8006) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
1 task
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…8006) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These have been deprecated for a year (since #5836) so we should remove them.
This cleanup is a prerequisite to supporting Transformers v5 style RoPE configuration (per layer type).