[CI/Build] Update LM Eval Version in AMD CI#27944
Merged
heheda12345 merged 1 commit intovllm-project:mainfrom Nov 4, 2025
Merged
[CI/Build] Update LM Eval Version in AMD CI#27944heheda12345 merged 1 commit intovllm-project:mainfrom
heheda12345 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: zhewenli <zhewenli@meta.com>
130688f to
0557a9a
Compare
heheda12345
reviewed
Nov 4, 2025
| mteb[bm25s]>=1.38.11, <2 | ||
|
|
||
| # Required for eval tests | ||
| lm-eval[api] @ git+https://github.com/EleutherAI/lm-evaluation-harness.git@206b7722158f58c35b7ffcd53b035fdbdda5126d |
Collaborator
There was a problem hiding this comment.
Why are you pinning a specific commit instead of a release version?
Collaborator
Author
There was a problem hiding this comment.
@heheda12345 it's matching the version used in Nvidia: https://github.com/vllm-project/vllm/blob/main/requirements/test.txt#L446
heheda12345
approved these changes
Nov 4, 2025
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
Signed-off-by: zhewenli <zhewenli@meta.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: zhewenli <zhewenli@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR updates lm-eval deps used in the AMD CI to match the version used in Nvidia.
Test Plan
Before this fix, V1 Test others will complain about incompatible failure due to V0 deprecation:
After the fix, the issue is gone: https://buildkite.com/vllm/amd-ci/builds/842#019a46a0-7764-4405-bd41-e50e6ceb0505