[Bugfix] Python 3.10 compatibility for Self#27918
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Nov 1, 2025
Merged
[Bugfix] Python 3.10 compatibility for Self#27918DarkLight1337 merged 1 commit intovllm-project:mainfrom
Self#27918DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
requested review from
WoosukKwon,
robertgshaw2-redhat,
simon-mo and
youkaichao
as code owners
DarkLight1337
added
the
ready
DarkLight1337
requested review from
ProExpertProg,
hmellor,
houseroad,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a Python 3.10 compatibility issue by replacing typing.Self with typing_extensions.Self. Since typing.Self is only available in Python 3.11 and later, this change ensures backward compatibility. The modification is accurate and well-contained within vllm/config/structured_outputs.py. I find no issues with this change.
noooop
approved these changes
Nov 1, 2025
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #26519 (comment)
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.