[Bugfix] Fix KDA output#27905
Merged
youkaichao merged 2 commits intovllm-project:mainfrom Nov 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the output mechanism of the KimiDeltaAttention layer. The forward method's signature and implementation have been updated to write the result to a pre-allocated output tensor, rather than returning a new tensor. This change aligns the layer with vLLM's standard practice of using in-place operations for performance and compatibility with features like CUDA graphs. The modification is correct and resolves the bug by ensuring the layer conforms to the expected API.
Contributor
|
Thank you for your timely fix. LGTM. |
Member
|
Thanks for catching that—my mistake. |
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
5 tasks
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.