Skip to content

[Core][Bookkeeping] Update cu_num_accepted_tokens for all req_index #27629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njhill merged 3 commits into from
Oct 30, 2025
Merged

[Core][Bookkeeping] Update cu_num_accepted_tokens for all req_index #27629

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db7d81a
[Core][Bookkeeping] Update cu_num_accepted_tokens for all req_index
Jialin Oct 28, 2025
481a6a4
fix pyre complains
Jialin Oct 28, 2025
535721c
sampled_id_cnt -> num_sampled_ids
Jialin Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions vllm/v1/worker/gpu_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2321,11 +2321,19 @@ def _bookkeeping_sync(
sampled_ids = [-1] if req_idx not in invalid_req_indices_set else None
else:
sampled_ids = valid_sampled_token_ids[req_idx]

num_sampled_ids: int = len(sampled_ids) if sampled_ids else 0

if cu_num_accepted_tokens is not None:
cu_num_accepted_tokens.append(
cu_num_accepted_tokens[-1] + num_sampled_ids
)

if not sampled_ids:
continue

start_idx = self.input_batch.num_tokens_no_spec[req_idx]
end_idx = start_idx + len(sampled_ids)
end_idx = start_idx + num_sampled_ids
assert end_idx <= self.max_model_len, (
"Sampled token IDs exceed the max model length. "
f"Total number of tokens: {end_idx} > max_model_len: "
Expand All @@ -2341,11 +2349,6 @@ def _bookkeeping_sync(
req_state = self.requests[req_id]
req_state.output_token_ids.extend(sampled_ids)

if cu_num_accepted_tokens is not None:
cu_num_accepted_tokens.append(
cu_num_accepted_tokens[-1] + len(sampled_ids)
)

logprobs_lists = (
logprobs_tensors.tolists(cu_num_accepted_tokens)
if not self.use_async_scheduling and logprobs_tensors is not None
Expand Down