-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
fix: allow HuggingFace standard chat template params via **kwargs #27622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4636728
fix: allow HuggingFace standard chat template params via **kwargs
60a3ca5
Update vllm/entrypoints/chat_utils.py
wangln19 438f9e3
fix: allow HuggingFace standard chat template params via **kwargs
271245a
Merge branch 'main' into 1028-white-list
wangln19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the test in
tests/entrypoints/test_chat_utils.py?vllm/tests/entrypoints/test_chat_utils.py
Lines 1783 to 1806 in 5b3c35a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test as suggested.
I considered adding Kimi K2 to the test model registry, but decided against it for the following reasons:
Infrastructure overhead: Adding a new model to
tests/models/registry.pyrequires extensive configuration (tokenizer path, trust_remote_code settings, HF overrides, etc.), which would be significant effort for testing a single parameter filtering behavior.Generic fix: This change is not Kimi K2-specific. It enables support for any tokenizer that uses
**kwargsto receive HuggingFace standard parameters. The mock tokenizer approach tests the core logic more directly.Sufficient coverage: The updated test now includes:
The mock approach isolates the parameter filtering logic we're actually fixing, without coupling the test suite to a specific model that may have availability/licensing constraints.