[Feature] Refactor batch invariant fp8 DeepGEMM #27606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yewentao256 <[email protected]>
yewentao256
requested review from
mgoin,
pavanimajety,
robertgshaw2-redhat and
tlrmchlsmth
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the apply method in Fp8LinearMethod to simplify the logic for batch-invariant FP8 GEMM. The change reuses W8A8BlockFp8LinearOp for block-quantized weights, aligning the batch-invariant path with the non-batch-invariant path and replacing a dequantization fallback with a more performant quantized kernel path. While this is a good simplification, I've identified a potential issue related to the removal of a safety check for handling weight scales of square matrices, which could lead to incorrect behavior in some edge cases.
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: yewentao256 <[email protected]>
mgoin
reviewed
Nov 4, 2025
Member
Author
|
This PR could also fix #28249 |
mgoin
approved these changes
Nov 10, 2025
1 task
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Nov 13, 2025
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
khluu
pushed a commit
that referenced
this pull request
Nov 16, 2025
Signed-off-by: yewentao256 <[email protected]>
khluu
pushed a commit
that referenced
this pull request
Nov 16, 2025
Signed-off-by: yewentao256 <[email protected]> (cherry picked from commit 35d801f)
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
Signed-off-by: yewentao256 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #27127 (comment) @mgoin
We can reuse the code from fp8_utils to simplify the logic