[Bugfix] Fixed when return_token_ids=False, the first event still contains prompt_token_ids. - #27561
Merged
Merged
Conversation
…ains prompt_token_ids. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Collaborator
Author
|
/cc @ultmaster PTAL. |
…ains prompt_token_ids. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
marked this pull request as ready for review
October 27, 2025 08:44
chaunceyjiang
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
October 27, 2025 08:44
Collaborator
Author
|
Follow up #22587 /cc @njhill @youkaichao @DarkLight1337 PTAL. |
Member
You mean when |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Collaborator
Author
ohh, yes. thanks~ |
DarkLight1337
enabled auto-merge (squash)
October 27, 2025 08:48
1 task
Contributor
|
I've looked at the PR and it seems to be a bug introduced by me. Sorry. The PR looks good. |
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
…tains prompt_token_ids. (vllm-project#27561) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up #22587
FIX #27336
vllm/vllm/entrypoints/openai/protocol.py
Lines 1241 to 1250 in 3567816
Test Plan
main:
this pr:
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.