Skip to content

[Doc] Remove Molmo warning#27527

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337:molmo-warning
Oct 26, 2025
Merged

[Doc] Remove Molmo warning#27527
DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337:molmo-warning

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 26, 2025

Purpose

The underlying issue should be fixed by #26563 and #26873 already

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 26, 2025
@mergify
Copy link

mergify bot commented Oct 26, 2025

Documentation preview: https://vllm--27527.org.readthedocs.build/en/27527/

@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a warning related to the Molmo model from the documentation. The author states that the underlying issue has been fixed in previous pull requests, making the warning obsolete. The change is straightforward and aligns with the stated purpose. I have no further feedback.

@DarkLight1337 DarkLight1337 merged commit be7b55a into vllm-project:main Oct 26, 2025
10 of 11 checks passed
@DarkLight1337 DarkLight1337 deleted the molmo-warning branch October 26, 2025 08:22
ilmarkov pushed a commit to neuralmagic/vllm that referenced this pull request Nov 7, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants