Make engine core client handshake timeout configurable #27444
Make engine core client handshake timeout configurable #27444njhill merged 8 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
|
@eicherseiji @tlrmchlsmth this PR is closed but was not merged? why? how to deal with timeouts? |
Hi @pbelevich! I was able to resolve the timeout issue using the runai model loader + updating to a release w/ DeepGEMM warmup heuristics. We were not sure there were other legitimate cases where the client would time out. Do you have a repro? |
|
In our case running DeepSeek V3 on Mi300x timeout happens exactly when everything is loaded. I think having this option configurable would help in such cases. |
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
…i/vllm into config-client-timeout
|
Hi @eicherseiji, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
…27444) Signed-off-by: Seiji Eicher <seiji@anyscale.com>
…27444) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
…llm-project#86) * Make engine core client handshake timeout configurable (vllm-project#27444) Signed-off-by: Seiji Eicher <seiji@anyscale.com> * [BugFix] Support online dense model DP without overhead (vllm-project#30739) Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: njhill <nickhill123@gmail.com> --------- Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Nick Hill <nhill@redhat.com> Signed-off-by: njhill <nickhill123@gmail.com> Co-authored-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com>
…27444) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
…27444) Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Purpose
Configuration with timeout:
Test Plan
vllm/v1/engine/core_client.pyTest Result
CI test:
Manual test:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.